On Wed, 4 Feb 2026 19:11:18 GMT, Artur Barashev <[email protected]> wrote:
>> Implement certificate compression in TLS 1.3 using internally supported ZLIB >> compression algorithm. See RFC 8879 for more details: >> https://datatracker.ietf.org/doc/html/rfc8879 > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Correct message name in javadoc src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 969: > 967: * This method only applies to TLSv1.3. > 968: * > 969: * @apiNote The peer needs to support the underlying extension Instead of "underlying", say the specific extension so it's clear what needs to be supported, i.e. "compress_certificate extension". Also, I would change "needs to" to "must". src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 973: > 971: * to work. > 972: * > 973: * @implNote The SunJSSE provider supports only zlib compression. s/supports only/only supports/ (sounds better) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2790354867 PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2790359988
