> Currently implementation of the test relies on changing the last byte of the > cypher to mess up the padding lines. However if the last bit is already 0 the > padding will not be taken into account and the result will have no error but > will be a garbage output. Current test doesn't take this into account. > > The fix should encode the test text without padding and decode with padding > to make sure that the bad padding exception is thrown. > > Kudos to @djelinski for assisting with finding the issue vs RFC! > > Also added a bug id which was missing
Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed warning ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29612/files - new: https://git.openjdk.org/jdk/pull/29612/files/10afb4a1..e956a0a8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29612&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29612&range=00-01 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29612.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29612/head:pull/29612 PR: https://git.openjdk.org/jdk/pull/29612
