On Tue, 2 Dec 2025 10:08:11 GMT, Andrew Haley <[email protected]> wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 3194:
>
>> 3192: _umullv(Vd, Ta, Vn, Tb, Vm, Ts, lane);
>> 3193: }
>> 3194:
>
> These seem to be essentially identical except for one assertion.
>
> Suggestion: as elsewhere in class Assembler,` #define INSN` for the common
> pattern, then use it.
I used this format to mirror `pmull{2}` which has a similar structure. Open to
changing to the `INSN` format if that's better though
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27946#discussion_r2819104362
