On Mon, 9 Feb 2026 21:04:34 GMT, Anthony Scarpino <[email protected]> wrote:

> Please review the finalized PEM API at https://openjdk.org/jeps/8360563. The 
> most significant changes from the second preview, JEP 524 
> (https://openjdk.org/jeps/524), include:
> 
> - `PEM` is changed from a record to a class, with content stored in binary 
> form and data defensively copied.
> - `DEREncodable` is renamed to `BinaryEncodable` to more accurately reflect 
> the binary data stored in PEM text.
> - In `EncryptedPrivateKeyInfo`, the `encrypt` methods now accept 
> `BinaryEncodable`, and the `getKey()` and `getKeyPair()` methods no longer 
> include a `Provider` parameter.
> - A new `CryptoException` indicates failures during cryptographic processing 
> at runtime.
> 
> thanks

src/java.base/share/classes/java/security/CryptoException.java line 26:

> 24:  */
> 25: 
> 26: package java.security;

Suggest moving this to the `javax.crypto` package because of its name and it is 
more for crypto related errors.

src/java.base/share/classes/java/security/CryptoException.java line 38:

> 36:  * <p>This exception is not intended to represent internal
> 37:  * provider errors, which should be reported using {@link 
> ProviderException}.
> 38:  */

Need an `@since`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r2830317164
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r2830332106

Reply via email to