On Thu, 19 Feb 2026 03:00:39 GMT, Shawn Emery <[email protected]> wrote:
>> xinyangwu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> since the last revision:
>>
>> - Merge branch 'openjdk:master' into aes
>> - 8376164: Optimize AES/ECB/PKCS5Padding with parallel intrinsic
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1404:
>
>> 1402: }
>> 1403:
>> 1404: address
>> StubGenerator::generate_electronicCodeBook_encryptAESCrypt_multiBlock_Parallel()
>> {
>
> Would be nice to have a method description (input, outputs, which registers
> are used on which platforms) and the overall algorithm used for multi-block
> encryption/decryption.
Thank you for your review. I've added input and output descriptions similar to
other methods, but I noticed that those methods didn't provide the overall
algorithms. I'll add them if you think it's necessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2844654270
