On Mon, 23 Feb 2026 23:54:07 GMT, Valerie Peng <[email protected]> wrote:

>> This PR changes the `KeyStore.getInstance(File, ...) method` to use a 
>> different exception message when the keystore type is found but disabled 
>> through the "jdk.crypto.disabledAlgorithms" property.
>> 
>> Thanks in advance for the review~
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix typo found by Sean Mullan.

Marked as reviewed by mullan (Reviewer).

test/jdk/java/security/KeyStore/DisabledKnownType.java line 41:

> 39:         try {
> 40:             KeyStore ks = KeyStore.getInstance(new 
> java.io.File(cacertsPath),
> 41:                     "changeit".toCharArray());

Nit: cacerts is no longer password protected. This password will just be 
ignored.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29619#pullrequestreview-3850527666
PR Review Comment: https://git.openjdk.org/jdk/pull/29619#discussion_r2849544992

Reply via email to