On Tue, 17 Feb 2026 23:02:14 GMT, Andrew Haley <[email protected]> wrote:

>> Ben Perez has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Added vs_tail method to simplify various VSeq operations, updated 
>> generate_intpoly_assign()
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4857:
> 
>> 4855:     }
>> 4856:   }
>> 4857: 
> 
> Please refactor these. I'd try passing a pointer to virtual member function 
> or perhaps a macro.

I was trying to use a similar structure to other `VSeq` methods, like `vs_addv` 
for example. Could you say a bit more about why this other approach would be 
preferable?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27946#discussion_r2855160358

Reply via email to