On Wed, 11 Mar 2026 18:47:19 GMT, Weijun Wang <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed start and end as no longer neeeded > > test/jdk/sun/security/util/HexDumpEncoderTests.java line 83: > >> 81: result.shouldHaveExitValue(0); >> 82: final String resultFromFile = >> Files.readString( >> 83: Path.of(charset.name()+".txt")); > > Are you sure that when a name is passed in with `-Dfile.encoding=` then the > exact same string will be return by `Charset.defaultCharset().displayName()`? > I really don't know about it. In security we have aliases and I don't know if > there is something similar here. > > I suggest you ask review from an expert, or, if it were me I would pass the > file name into the process. It returns the `FILE_ENCODING = getProperty(props, "file.encoding");` value. Just a cleaner way of doing the same thing ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30021#discussion_r2923199048
