On Fri, 13 Mar 2026 10:15:25 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Not worth anticipating that. If it really happens, maybe we have a bug >> somewhere. > > But it also covers the new internal Instant methods and will flag if there > are any broken changes in either `TimeParsing`, `DerValue` or > `DerInputStream`. I'm not sure if leaving the methods uncovered is a good > idea. > If these methods will end up being completely removed in the future - this > check could be removed as well. But since this is not happening right now I'd > personally prefer to keep it I mean we just check `!d0.equals(d1)` and ignore the millisecond check. This makes the test more sensitive and could reveal a bug in the future. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r2931226226
