On Sun, 15 Mar 2026 11:41:06 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Optimize import
>> - Fix "Server not ready" error in createPKI
>
> test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java line 104:
>
>> 102:
>> 103: // Turn on TLS debugging
>> 104: static boolean debug = true;
>
> I think this either could be removed entirely and just make a
> `javax.net.debug ` option in `@run` or `static boolean debug =
> Boolean.getBoolean("test.debug");`. Could you please change it ?
>
> I personally prefer the first option here, but ultimately it’s up to you.
There are many places read the value of `debug`. So seems it's more suitable
to choose the second option.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30212#discussion_r2957660294
