On Fri, 27 Mar 2026 12:46:27 GMT, Sean Mullan <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to have an implementation note
>
> src/java.base/share/classes/javax/crypto/KEM.java line 372:
>
>> 370: * this method’s {@code @throws} clause. Implementators of
>> ML-KEM
>> 371: * algorithm should avoid revealing a decapsulation operation
>> 372: * failure or cryptographic conditions.
>
> What do you mean by "cryptographic conditions" - do you need these words? I
> also think you should say what an implementation should do in this case. Here
> is a rewording suggestion:
>
> "Implementations of the ML-KEM algorithm should not reveal a decapsulation
> operation failure and instead return a pseudorandom secret key."
Done as suggested. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30225#discussion_r3001519231
