On Thu, 16 Apr 2026 14:03:33 GMT, SendaoYan <[email protected]> wrote:

> > All, or most of the certificate infra tests in general assume an Internet 
> > connection, so I think it is a basic requirement and the test should fail 
> > if it cannot make a connection. The success of these tests depends on 
> > verifying downloaded security artifacts,
> 
> Seems all the CA tests which need internet connection are `/manual`, this 
> means those tests will not selected by CI, but only this test is non 
> `/manual` when backported to jdk8u. So I want to make this change for this 
> test.

That's not a good reason to make a change in the mainline for an 8u specific 
issue. Why is the test in 8u not manual like the others?

> 
> > so you don't want to miss issues where the CA may have made some changes 
> > and the tests need to be updated to use a different URL. I don't think it 
> > is appropriate to make one test workaround this.
> 
> I think you are right. Maybe the skippedEsception is not suitable. But the 
> connection check to Sectigo before test run maybe usefully. Should we keep 
> the connection check but report failure rather than throw skippedException.

I don't think the connection check is useful.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30740#issuecomment-4330373080

Reply via email to