> The powershell binary is required to run these tests but in the GitHub
> workflow that runs tests (specifically, in test.yml), we reset the PATH
> environment variable on Windows, causing the GitHub workflow to fail if
> you run these tests.  The tests pass locally since local test runs don't
> modify PATH.
> 
> To make these tests pass in GitHub workflows, this patch updates the
> tests to refer to PowerShell using the canonical path on Windows.  See
> https://github.com/raneashay/openjdk-jdk/actions/runs/25680763981/job/75401590988
> for a sample workflow run of the tier2 part1 tests, which include the
> CngCipher and DupAlias tests.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Ashay Rane has updated the pull request incrementally with two additional 
commits since the last revision:

 - Add missing year to copyright notice.
 - Move `powerShellPath()` to `jdk.test.lib.os.windows.FileUtils`
   
   This avoids having to duplicate the function in individual tests.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31127/files
  - new: https://git.openjdk.org/jdk/pull/31127/files/6d8eeea1..1065676a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31127&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31127&range=00-01

  Stats: 52 lines in 3 files changed: 36 ins; 12 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/31127.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31127/head:pull/31127

PR: https://git.openjdk.org/jdk/pull/31127

Reply via email to