On Wed, 22 Apr 2026 14:52:13 GMT, Chen Liang <[email protected]> wrote:

>> This PR removes the experimental JVMCI feature and all usages and references 
>> of it, including references to Graal. For more details on the rationale, 
>> please see the issue description.
>> 
>> This change was constructed in several steps:
>>  1. Remove all folders directly related to JVMCI.
>>  2. Go through one folder at a time and remove code relating to matches for 
>> the regex `([Jj][Vv][Mm][Cc][Ii])|([Gg]raal)|vm.ci|[Gg]alahad` and 
>> immediately obvious dead code.
>>  3. Filter the `git blame` for each file for JVMCI related commits and check 
>> if that code is now dead. 
>> 
>> ### Note to Reviewers
>> 
>> Each commit contains is limited to a subfolder or a change spanning further 
>> so you can take look at a piece of the codebase you are familiar with. I 
>> recommend you look at individual commits and select "Ignore Whitespace" in 
>> the Github UI.
>> 
>> ### Testing
>> 
>>  - [x] Github Actions
>>  - [x] tier1-6 linux-x64, linux-aarch64, windows-x64, macosx-aarch64, 
>> macosx-x64
>>  - [x] build linux-zero, linux-arm, linux-riscv, linux-ppc (LE & BE) 
>> fastdebug with features C1+C2, C2 only, C1 only
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.base/share/classes/jdk/internal/vm/VMSupport.java line 260:
> 
>> 258:     private static void encodeAnnotation(DataOutputStream dos, 
>> Annotation a) throws Exception {
>> 259:         Class<? extends Annotation> type = a.annotationType();
>> 260:         Map<String, Object> values = AnnotationSupport.memberValues(a);
> 
> Ideally AnnotationSupport.memberValues and 
> AnnotationInvocationHandler.memberValues can be nuked too. 
> https://bugs.openjdk.org/browse/JDK-8382841

Good catch, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30834#discussion_r3138633993

Reply via email to