On Mon, 18 May 2026 04:38:59 GMT, Rajan Halade <[email protected]> wrote:

> Updated these two tests to generate and use certificates. 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/sun/security/ssl/X509KeyManager/PreferredKey.java line 35:

> 33:  * @summary X509KeyManager implementation for NewSunX509 doesn't return 
> most
> 34:  *          preferable key
> 35:  * @run main/othervm PreferredKey

Should we keep the new java process flag 'main/othervm'

test/jdk/sun/security/ssl/X509KeyManager/SelectOneKeyOutOfMany.java line 143:

> 141:     }
> 142: 
> 143:     private static X509Certificate createSelfSignedCert(KeyPair caKeys, 
> String keyAlg)

Duplicated createSelfSignedCert in both files. Should we consider a 
package-private helper in the same directory or a shared test utility in a 
follow-up to reduce drift

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31186#discussion_r3256863240
PR Review Comment: https://git.openjdk.org/jdk/pull/31186#discussion_r3256855594

Reply via email to