On Mon, 18 May 2026 17:04:16 GMT, Weijun Wang <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comments > > src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line > 488: > >> 486: // For the unlikely case a non-PBE cipher is used, get >> the OID. >> 487: algId = new >> AlgorithmId(AlgorithmId.get(algorithm).getOID(), >> 488: c.getParameters()); > > This is not always available. For example, if `algorithm` is > "AES/CBC/NoPadding", it does not have an OID. OIDs are defined for a keysize, > like "AES_128/CBC/NoPadding". This part was for best effort if someone used a non-standard PBE algorithm. It was not meant to catch every case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3261054066
