On Thu, 21 May 2026 23:51:44 GMT, Brent Christian <[email protected]> wrote:
>> src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java
>> line 255:
>>
>>> 253: try {
>>> 254: checkSecurity("exclusive");
>>> 255: checkState();
>>
>> What's the reason that these checks are done within the try-finally whereas
>> the `openLogicalChannel()`-checks are done outside of the try-finally?
>
> I think maybe github is rendering diffs in a confusing way?
> In all cases, I add a new, outer try/finally block (for the
> reachabilityFence()) around the existing code.
> `openLogicalChannel()` has the checks within this new try/finally block, as
> do the other methods.
> Try enabling "Hide whitespace" (in the "gear" menu) and hopefully that will
> look better.
Great catch, there was something wrong with the diff display.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3288327376
