On Thu, 28 May 2026 13:24:47 GMT, Matthew Donovan <[email protected]> wrote:
>> This timeout may be caused by different code paths used to resolve
>> `InetAddress.getLoopbackAddress()` in the server thread and
>> `factory.createSocket("localhost",...)` in the client thread. I updated the
>> test to use getLoopbackAddress() for both threads.
>>
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains seven additional
> commits since the last revision:
>
> - changed to use Utils.adjustTimeout()
> - Merge branch 'master' into disable-cipher-suites
> - reverted a bunch of changes; changed to use timeout factor for accept()
> call
> - Merge branch 'master' into disable-cipher-suites
> - updated test to enable server thread to exit quickly if client has
> connection error
> - Merge branch 'master' into disable-cipher-suites
> - 8374454: Test
> sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java from
> JDK-8356544 shows intermittent timeouts
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 78:
> 76:
> 77: serverPort = serverSocket.getLocalPort();
> 78: serverSocket.setSoTimeout(WAIT_FOR_SERVER_SECS * 3000);
How about:
private static final int ACCEPT_TIMEOUT_MS = (int)Utils.adjustTimeout(15_000);
// ...
serverSocket.setSoTimeout(ACCEPT_TIMEOUT_MS);
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 126:
> 124: runClient(Boolean.parseBoolean(args[0]),
> Integer.parseInt(args[1]));
> 125: } catch (Exception exc) {
> 126: Files.writeString(Path.of("client-failed"), "failed");
Seems useless write the file "client-failed"
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 138:
> 136: System.out.println("Client output:");
> 137: System.out.println(oa.getOutput());
> 138: if (serverException != null) {
Should we keep this Exception check.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3346642840
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3346653019
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3346663373
