On Fri, 29 May 2026 08:40:49 GMT, Daniel Fuchs <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2732 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8385344: [lworld] ProblemList >> tools/javac/platform/CanHandleClassFilesTest.java with --enable-preview >> >> Reviewed-by: fparain >> - 8385301: [lworld] Remove >> serviceability/sa/TestJhsdbJstackMixedWithXComp.java from problem list >> >> Reviewed-by: dsimms >> - 8385331: [lworld] adjust ValueComparisonTest.java again to work around >> JDK-8370769 >> >> Reviewed-by: dsimms >> - 8385311: [lworld] TypePtr::eq() should use accessor method for _offset >> >> Reviewed-by: mchevalier >> - 8385259: [lworld] Clean up LP64 in x86 code >> >> Reviewed-by: dlong, thartmann >> - Merge >> >> Merge jdk-27+23 >> - 8384924: [lworld] misc cleanups >> >> Reviewed-by: thartmann >> - 8385167: [lworld] C1: minor cleanups >> >> Reviewed-by: dlong, thartmann >> - 8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg >> >> Reviewed-by: thartmann >> - ... and 2722 more: https://git.openjdk.org/jdk/compare/86637704...b3b4a2cb > > test/lib/jdk/test/lib/net/HttpHeaderParser.java line 92: > >> 90: public HttpHeaderParser(InputStream is) throws IOException, >> ProtocolException { >> 91: parse(is); >> 92: } > > Would the correct way of getting rid of this > `@SuppressWarnings("initialization")` annotation here be to change the > constructor to either call `this();` or `super();` before `parse(is);`? > > I am not saying that it should happen in this PR but I would like to > understand what kind of followup work might be needed in the networking area. > Thanks! In this particular case, I think the equivalent is to add `super();` before `parse(is)`, which is an instance call not allowed in prologue when all implicit `super()` calls are injected to the end of constructor bodies instead. But using `this()` is probably a better way to convey intentions. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3351204681
