On Thu, 21 May 2026 20:00:36 GMT, Erik Joelsson <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2754 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - Merge >> >> Merge jdk-27+24 >> - 8385674: [lworld] TestNullableInlineTypes.java fails after JDK-8325632 >> >> Reviewed-by: mchevalier >> - 8385652: [lworld] RedefineClasses should use stack map frame name >> >> Reviewed-by: fparain >> - 8384107: [lworld] Update runtime/contended tests to run the same testing >> for value classes >> >> Reviewed-by: fparain, lmesnik >> - 8385600: [lworld] DA/DU issues with strict fields >> >> Reviewed-by: vromero >> - 8384897: [lworld] this.staticField should be restricted in early >> construction context >> >> Reviewed-by: liach, vromero >> - 8385601: [lworld] Update testing documentation for the ValueClassPlugin >> jtreg option >> >> Reviewed-by: lmesnik >> - 8385569: [lworld] Apply JDK-8343767 to Valhalla specific StubRoutines >> >> Reviewed-by: fparain, vlivanov >> - 8385581: [lworld] Remove the experimental JVMCI feature >> 8382708: [lworld] JVMCI support for Value Objects >> 8372605: [lworld] >> compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJava*.java >> fail with --enable-preview >> >> Reviewed-by: thartmann >> - ... and 2744 more: https://git.openjdk.org/jdk/compare/2c7efc08...9e804255 > > make/CompileJavaModules.gmk line 150: > >> 148: # We cannot compile directly into the desired directory because >> it's the >> 149: # compiler which creates the original '<module>/<classpath>/...' >> hierarchy. >> 150: TEMP_OUTPUTDIR := $(SUPPORT_OUTPUTDIR)/$(PREVIEW_CLASSES_LABEL) > > Avoid the word "temporary" when describing this procedure. The files aren't > removed after copying (and they shouldn't be), a better word describing these > class files or the directory they are compiled into would be "intermediate", > or just name them for what they are "preview". In this case, just remove the > word "temporary" from the description. The variable name should also be > changed. > > Suggestion: > > # Compile preview classes into a separate directory, and then copy into > the > # correct output path location. We cannot compile directly into the > desired > # directory because it's the compiler which creates the original > # '<module>/<classpath>/...' hierarchy. > PREVIEW_OUTPUTDIR := $(SUPPORT_OUTPUTDIR)/$(PREVIEW_CLASSES_LABEL) See the following bug comment for my analysis: https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884574&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884574 Summary: Cleaning up the word "temporary" in the comments and renaming the TMP variable are good cleanups. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3351886145
