On Thu, 4 Jun 2026 05:30:51 GMT, Alan Bateman <[email protected]> wrote:
>> I made this change, so I could [revert >> `test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001.java`](https://github.com/openjdk/jdk/commit/a7ecceb9bd1a99f0674b76a852cc3ab2c25326a4#diff-cbe0d206a08bb013eee2a8cfcc05b7298f91ae960cd17448d2960346295d5c65) >> to mainline equivalent. I don't think this is being tested with value >> classes unfortunately, seems the existing tests are the ones in jdi around >> the test I last modified. However, these tests are run with preview-enabled >> VM so the "SUPER" trusting does work with preview identity classes. >> >> I don't know if core libs or hotspot (serviceability) would be in charge of >> adding such a value class test. > > I've created a test, should I propose that for the lworld branch to its to > this PR when sync'ed up? Sure! More than pleasured to have you contribute tests to the valhalla repo. The lworld branch is regularly tested on Oracle's CIs so the earlier the test gets in on lworld, the more coverage it gets over time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3353751081
