On Thu, 11 Jun 2026 18:45:06 GMT, Ashay Rane <[email protected]> wrote:

> Every time an exception object is created, the constructor calls
> `fillInStackTrace()`, which has to walk the call stack to record every
> frame.  This is expensive, and it's also unnecessary if the exception is
> never thrown.  There are a few instances in various parts of the JDK
> libraries where we create an exception in the dominator block but don't
> always throw it.  This patch fixes those cases so that if the exception
> is not going to be thrown, it is never created in the first place.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Ashay - did you use a scanning tool to find these? The motivation seems to be 
performance but it's not clear that there is anything performance critical here 
(esp. with the changes to keytool and jshell init). 

The exception when using LDAP over TLS fails is probably something for a 
separate issue/discussion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31487#issuecomment-4688650466

Reply via email to