On Fri, 12 Jun 2026 00:48:00 GMT, Shawn Emery <[email protected]> wrote:

> This fix includes throwing the correct exception when an offset for the key 
> length check would cause an integer overflow therefore throwing the wrong 
> exception.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/javax/crypto/spec/DESKeySpec/OffsetKey.java line 29:

> 27:  * @summary Test DES[ede]KeySpec for negative and integer overflow offsets
> 28:  */
> 29: import java.security.InvalidKeyException;

'import InvalidKeyException' seems useless.

test/jdk/javax/crypto/spec/DESKeySpec/OffsetKey.java line 67:

> 65:             throw new Exception("expected 
> ArrayIndexOutOfBoundsException");
> 66:         } catch (ArrayIndexOutOfBoundsException aiobe) {}
> 67:         try{

There are several `try{` missed a whitespace

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31494#discussion_r3407693824
PR Review Comment: https://git.openjdk.org/jdk/pull/31494#discussion_r3407692860

Reply via email to