On Mon, 15 Jun 2026 14:21:32 GMT, Andrew Dinn <[email protected]> wrote:
>> Shawn Emery has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on adinn's comments > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7678: > >> 7676: /** >> 7677: * Arithmetic polynomial multiplicaiton in Curve25519. The >> algorithm mimics >> 7678: * the version in Java, including the use of all columns (no folding >> method). > > Please mention class `IntegerPolynomial25519` or file > `IntegerPolynomial25519.java` to make it easier for maintainers to find the > source. Thank you for your review. Done. > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7720: > >> 7718: const int32_t columns = limbs * 2; >> 7719: const uint64_t mask = 0x7FFFFFFFFFFFFULL; >> 7720: const uint64_t CARRY_ADD = 0x4000000000000ULL; > > It might be clearer to construct these from bpl rather than leave readers to > count the number of zeroes: > > Suggestion: > > const uint64_t mask = ((1ULL << bpl) - 1ULL); > const uint64_t CARRY_ADD = (1ULL << (bpl - 1)); Good idea. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31409#discussion_r3424736270 PR Review Comment: https://git.openjdk.org/jdk/pull/31409#discussion_r3424736608
