On Fri, 12 Jun 2026 11:13:55 GMT, Hai-May Chao <[email protected]> wrote:

>> This change adds the `jdk.crypto.legacyAlgorithms` security property to 
>> `java.security`. At the JCE layer, the JDK checks this property and emits a 
>> runtime warning when a configured legacy algorithm is requested.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Split legacy alg detection from capturing the caller

src/java.base/share/classes/java/security/KeyStore.java line 931:

> 929:      * the security property value.
> 930:      *
> 931:      * The JDK Reference Implementation additionally uses

Since there is now more than one property for this Implementation Note, I think 
you should reword and change this to a bulleted-list just like the 
`KeyStore.getInstance(String)` method, which already has more than one property 
in its Implementation Note.

This comment applies to all the APIs in the PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31472#discussion_r3435906790

Reply via email to