On Mon, 22 Jun 2026 13:04:11 GMT, Jorn Vernee <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2822 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8386690: [lworld] cherry-pick JDK-8386124 Test >> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does >> not match >> >> Reviewed-by: liach >> - 8385743: [lworld] investigate and address build related comments in the >> Valhalla PR >> >> Reviewed-by: liach, erikj >> - 8376346: [lworld] Basic Shenandoah support >> >> Reviewed-by: qamai >> - 8386598: [lworld] C1 acmp profiling fix and minor cleanup >> >> Reviewed-by: mchevalier >> - 8386618: [lworld] Remove unused entry_guard_Relocation >> >> Reviewed-by: chagedorn, jsjolen, jsikstro >> - Merge >> >> Merge jdk-28+2 >> - 8386623: [lworld] Cleanup module support for system modules in JDK >> exploded build with preview resources >> >> Reviewed-by: liach >> - 8386316: [lworld] Replace Valhalla since version with 28 >> >> Reviewed-by: darcy >> - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...426cc065 > > src/java.base/share/classes/jdk/internal/misc/Unsafe.java line 1881: > >> 1879: return compareAndSetReference(o, offset, valueType, >> expected, x); >> 1880: } else { >> 1881: return weakCompareAndSetReferencePlain(o, offset, >> expected, x); > > Looks like this is delegating to the wrong method > > Suggestion: > > return weakCompareAndSetReferenceAcquire(o, offset, expected, x); Yeah, this can definitely not be a weaker access than requested. > src/java.base/share/classes/jdk/internal/misc/Unsafe.java line 1908: > >> 1906: return compareAndSetReference(o, offset, valueType, >> expected, x); >> 1907: } else { >> 1908: return weakCompareAndSetReferencePlain(o, offset, >> expected, x); > > Same here > > Suggestion: > > return weakCompareAndSetReferenceRelease(o, offset, expected, x); Yeah, this can definitely not be a weaker access than requested. > src/java.base/share/classes/jdk/internal/misc/Unsafe.java line 1935: > >> 1933: return compareAndSetReference(o, offset, valueType, >> expected, x); >> 1934: } else { >> 1935: return weakCompareAndSetReferencePlain(o, offset, >> expected, x); > > Suggestion: > > return weakCompareAndSetReference(o, offset, expected, x); Yeah, this can definitely not be a weaker access than requested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3466589840 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3466592735 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3466595052
