On Tue, 23 Jun 2026 12:44:57 GMT, Andreas Chmielewski <[email protected]> wrote:
> These mappings were previously missing, causing > jdk.tls.disabledAlgorithms constraints using component names (e.g. > "AES_128_GCM", "AES_256_GCM", "CHACHA20_POLY1305") to not > consistently match the corresponding TLS cipher suites. > > > > > --------- > - [ x] I confirm that I make this contribution in accordance with the > [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 2: > 1: /* > 2: * Copyright (c) 2015, 2026, Oracle and/or its affiliates. All rights > reserved. Is this a brand new test of you re-used some of the Oracle's code? Please correct the copyright if it's a brand new test. test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 26: > 24: /* > 25: * @test > 26: * @summary Test TLS 1.3 disabled algorithms behavior Please update the summary like in the other test. test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 27: > 25: * @test > 26: * @summary Test TLS 1.3 disabled algorithms behavior > 27: * @modules jdk.crypto.ec Do we need this module? test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 28: > 26: * @summary Test TLS 1.3 disabled algorithms behavior > 27: * @modules jdk.crypto.ec > 28: * @library /test/lib /javax/net/ssl/templates `/javax/net/ssl/templates` is not needed. test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 29: > 27: * @modules jdk.crypto.ec > 28: * @library /test/lib /javax/net/ssl/templates > 29: * @run main/othervm -enablesystemassertions TLS13DisabledAlgorithm Why we need `-enablesystemassertions` flag? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3475578417 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3475558303 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3475560218 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3475562294 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3475564501
