On Thu, 25 Jun 2026 21:23:13 GMT, Valerie Peng <[email protected]> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test - add return
>
> test/jdk/sun/security/smartcardio/TestCleaner.java line 53:
>
>> 51: * CardImpl from becoming unreachable and being collected/cleaned.
>> 52: */
>> 53: public class TestCleaner extends Utils {
>
> The newer practice is to throw `jtreg.SkippedException` when a test is
> skipped. We could follow the same pattern.
Yes, I like that a lot. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3539267704
