On Fri, 10 Jul 2026 20:43:49 GMT, Daisuke Yamazaki <[email protected]> wrote:

>> src/jdk.jartool/share/man/jarsigner.md line 188:
>> 
>>> 186: proprietary keystore type (format) named `JKS`. It protects each 
>>> private key
>>> 187: with its individual password, and also protects the integrity of the 
>>> entire
>>> 188: keystore with a (possibly different) password.
>> 
>> Let's also remove the last 2 sentences of this paragraph. I don't think we 
>> should mention JKS at all, as it is discouraged. Users can always find what 
>> other keystore implementations there are via other docs, such as the JDK 
>> Providers Guide.
>
> Thanks for your review.
> 
> Should we remove the preceding sentence as well?
> 
>> There is another built-in implementation, provided by Oracle.
> 
> Although the statement is correct, it provides little information on its own 
> and would make the paragraph feel abrupt after removing the following two 
> sentences.

Yes, good catch - please remove that sentence too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31740#discussion_r3570822689

Reply via email to