On Wed, 29 Jul 2026 16:21:59 GMT, Michael McMahon <[email protected]> wrote:
>> Remove the SSLTubeSubscriber#Monitor class, related system property, code, >> and all uses. The class provided debug information that is also available in >> the httpclient debug logs, and was only used by 2 tests. >> >> No new tests. Existing tests continue to pass. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.net.http/share/classes/jdk/internal/net/http/common/SSLFlowDelegate.java > line 529: > >> 527: requestMoreDataIfNeeded(); >> 528: return; >> 529: } > > Why are these lines removed, and also the two lines above that set the > `handshaking` flag? they were flagged by IntelliJ as dead code; `handshaking` is always false. It is initialized to `false` at the beginning of the `while` loop, and only set to `true` immediately before `continue` or `break` (i. e. just before being reset back to `false` or going out of scope). I also tried changing this to `if (!complete)`, but that resulted in test failures. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32089#discussion_r3676228363
