On Tue, 18 Aug 2026 15:13:33 GMT, Sean Mullan <[email protected]> wrote:
>> https://bugs.openjdk.org/browse/JDK-8370245 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/sun/security/pkcs12/ParamsPreferences.java line 1: > >> 1: /* > > Should you add some tests where the "keystore.pkcs12.macAlgorithm" is set to > PBEWithHmacSHA256? I'll add some. > test/jdk/sun/security/pkcs12/ParamsPreferences.java line 119: > >> 117: PBES2, HmacSHA256, AES_256$CBC$NoPadding, 10000, >> 118: PBES2, HmacSHA256, AES_256$CBC$NoPadding, 10000, >> 119: PBMAC1, 10000); > > Interesting - so even though "keystore.pkcs12.macAlgorithm" is set to "NONE", > you still check for PBMAC1? The first `Map.of(...)` on line 111 sets system properties and the second on line 114 sets security properties. So "NONE" is being overridden by "" so the default `PBEWithHmacSHA256` is used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32398#discussion_r3806021192 PR Review Comment: https://git.openjdk.org/jdk/pull/32398#discussion_r3806022293
