On Thu, 13 Aug 2026 19:06:19 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed unused import
>
> src/java.base/share/classes/sun/security/ec/ECDSASignature.java line 160:
>
>> 158: protected void engineUpdate(byte[] b, int off, int len)
>> 159: throws SignatureException {
>> 160: if (len > precomputedDigest.length - offset) {
>
> Do you need to add a comment that when last `update` already overflowed then
> `precomputedDigest.length - offset` is negative and the check always
> succeeds? It took me some time to confirm this.
Sure, I can add a comment to make it clearer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32308#discussion_r3855962206
