On Mon, 7 Sep 2026 10:50:19 GMT, Martin Doerr <[email protected]> wrote:

> Thanks for fixing it! LGTM, but I'm not an expert for this Windows code. Are 
> there more similar issues?

We have only a few calls to OpenProcessToken, see

https://github.com/openjdk/jdk/blob/4c98aa9d077519cd51784ef7469e2aa4242d5143/src/java.base/windows/native/libjava/ProcessHandleImpl_win.c#L501

https://github.com/openjdk/jdk/blob/4c98aa9d077519cd51784ef7469e2aa4242d5143/src/hotspot/os/windows/perfMemory_windows.cpp#L747

https://github.com/openjdk/jdk/blob/4c98aa9d077519cd51784ef7469e2aa4242d5143/src/hotspot/os/windows/os_windows.cpp#L3016

but seems there we always do a CloseHandle call on the tokenHandle.
So I think the other calls are fine,

@dholmes-ora can you maybe comment or forward to someone from the jdk.security  
area ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32689#issuecomment-5569596780

Reply via email to