On Fri, 11 Sep 2026 14:53:47 GMT, Weijun Wang <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line >> 2519: >> >>> 2517: * 30 84 -- -- -- -- 02 01 03 30 83 -- -- -- 06 09 2A 86 48 86 F7 >>> 0D 01 07 >>> 2518: * 30 84 -- -- -- -- 02 01 03 30 84 -- -- -- -- 06 09 2A 86 48 86 >>> F7 0D 01 >>> 2519: * 30 -- 02 01 03 30 0B 06 09 2A 86 48 86 F7 0D 01 07 01 >> >> You added two new entries (one in `PKCS12_HEADER_PATTERNS`, and one in >> `PKCS12_HEADER_PATTERNS_SHORT`). Please also add 2 lines in the comment. > > In fact, how worth is it using 2 different patterns? Can we just always use > > 30 -- 02 01 03 30 0B 06 09 2A 86 48 86 F7 0D 01 07 01 -- -- -- -- -- -- > > You've always padded zeroes when it's short. Good suggestion: I'll use one pattern. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32357#discussion_r3992286482
