On Tue, 29 Sep 2026 16:35:51 GMT, Matthew Donovan <[email protected]> wrote:

>> This test targets some code coverage gaps with the `SSLLogger` namely around 
>> the use of `formatMapEntry(..)` and `log(...)`with a throwable overload. The 
>> test captures `SSLLogger` output in a buffer and asserts that the correct 
>> info was logged. Reflection was required to reach the `log(...)` with a 
>> throwable overload as there is no way access SSLLogger's private console 
>> logger and target the method otherwise.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> There's a comment in JDK-8361344 to add coverage to `Utilities.indent(String 
> source, String prefix)` as part of this commit.

> @mpdonova Its covered indirectly via `SSLLogger.info()` which 
> calls`formatMapEntry()` then `Utilities.indent(String)` and 
> `Utilities.indent(String, String)`. I can add an explicit tests with null etc 
> if thats what you had in mind.

That's fine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33056#issuecomment-5931608711

Reply via email to