On Tue, 13 Oct 2026 17:25:48 GMT, Sean Mullan <[email protected]> wrote:
>> test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java line 189:
>>
>>> 187: Path jdkJmodsPath = Path.of(System.getProperty("test.jdk"),
>>> "jmods");
>>> 188: Path jdkJmodsCopyPath = Path.of(TEST_DIR, "jmodsCopy");
>>> 189: FileUtils.copyDirectory(jdkJmodsPath, jdkJmodsCopyPath);
>>
>> I assume this will fail if configured with `--enable-linkable-runtime`. Look
>> at the existing jlink tests to see examples how they work or skip with these
>> builds.
>
> I believe the test already does this. See lines 150-152:
>
>
> helper = Helper.newHelper(LINKABLE_RUNTIME);
> if (helper == null) {
> throw new SkippedException("Test not run: no linkable runtime");
> }
Can you test it? I assume this should be `if (LINKABLE_RUNTIME) { skip }`,
otherwise it will get a helper and then fail because there isn't a "jmods"
directory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31884#discussion_r4268737316
