On Wed, 21 Oct 2026 11:06:23 GMT, Chris Hegarty <[email protected]> wrote:

>> Fixes a rare NullPointerException in X500Principal.hashCode() and equals() 
>> on aarch64, where thisX500Name is null.
>> 
>> I made `thisX500Name` final. The field was non-final only because 
>> `readObject` sets it, and deserialization doesn't run a constructor. I used 
>> `Unsafe.putReference` in `readObject` for that, which is how the JDK handles 
>> this elsewhere:
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chris Hegarty has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 
> x500principal-safe-publication
>  - volatile
>  - revert
>  - Make X500Principal.thisX500Name final to fix unsafe publication

No don't drop it, and thank you for taking the time to submit a patch. I just 
want to make sure a few eyes get on it since it is in security related code.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33253#issuecomment-6318766545

Reply via email to