On Tue, 20 Oct 2026 12:43:17 GMT, Larry <[email protected]> wrote: >> @LangruiZhou please enable GHA testing in your branch. > > Hi @vnkozlov, thank you for the review comment. I understand the concern > about complexity. > >> I am not sure about this optimization. On one hand, the performance >> improvement of the **micro** benchmark is impressive. On the other hand, >> your changes complicated the code which became harder to understand and >> maintain. > > To clarify, the change does not introduce a new algorithm: it makes the > non-AVX-512 reduction follow the same L_128_done + L_barrett sequence already > used by kernel_crc32_avx512(), with the same K_128_64/K_64_32 constants and > masks. The adaptations for kernel_crc32() are mechanical only: the constants > come from _crc_by128_masks, and the masks are built in a register instead of > being loaded from the AVX-512 mask table. > > Would you consider this acceptable, or would you prefer a different way to > structure/comment the reduction? I'll revise accordingly.
@LangruiZhou please re-run your performance testing with your latest changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33342#issuecomment-6426225263
