On Tue, 27 Oct 2026 21:23:40 GMT, Weijun Wang <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Weijun's comments
>
> src/java.base/share/classes/sun/security/util/DerOutputStream.java line 510:
>
>> 508: */
>> 509: public DerOutputStream putTime(Instant d) {
>> 510: return (d.isBefore(utcLow) || d.isAfter(utcHigh)) ?
>> putGeneralizedTime(d) : putUTCInstant(d);
>
> Do we need to truncate `d` to second before checking `isBefore` and `isAfter`?
Yes, you're right, added in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r4460906578
