On Tue, 3 Nov 2026 19:52:33 GMT, Volodymyr Paprotski <[email protected]> wrote:
>> Larry has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8394260: Refine Adler32 AVX2 loop >> >> Reduce the AVX2 hot loop to one conditional backedge and remove the >> redundant yprev_a copy by accumulating ya before updating it. >> >> Factor the modulo BASE sequence into a helper and extend the Adler32 JMH >> parameters to cover the small sizes. > > src/hotspot/cpu/x86/stubGenerator_x86_64_adler.cpp line 241: > >> 239: __ vphaddd(xa, xa, xa, Assembler::AVX_128bit); >> 240: __ vphaddd(xb, xb, xb, Assembler::AVX_128bit); >> 241: __ vphaddd(xsa, xsa, xsa, Assembler::AVX_128bit); > > Did you try your optimization idea on these as well, on the 512 path? I guess > there is enough independent work here.. Not yet. I haven’t had time to try it on the AVX-512 path, but I plan to investigate and address it as a follow-up in JDK-8396416 (https://bugs.openjdk.org/browse/JDK-8396416). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4463098070
