On Wed, 4 Nov 2026 16:53:38 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Larry has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8394260: Align AVX-512 Adler32 loop entry
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_adler.cpp line 423:
>
>> 421:
>> 422: reduce_mod_base(a_d, rcx);
>> 423: reduce_mod_base(b_d, rcx);
>
> If `size` is 0 at this point these 2 calls will be executed again at
> `FINAL_REDUCE`.
Thanks. done
> test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java line 169:
>
>> 167: byte[] bytes = new byte[M + offset];
>> 168: if (Boolean.getBoolean("allFF")) {
>> 169: Arrays.fill(bytes, (byte) 0xFF);
>
> Consider using the `0xfff0fff0` pattern instead.
done;
> test/micro/org/openjdk/bench/java/util/TestAdler32.java line 40:
>
>> 38:
>> 39: @Param({"1", "2", "4", "8", "15", "16", "24", "31", "32",
>> 40: "64", "128", "256", "512", "1024", "2048", "5012", "8192",
>
> consider adding `4096` which you use in benchmark in Description.
done;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4476248140
PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4476250402
PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4476247649
