On Wed, 4 Nov 2026 23:30:30 GMT, Sandhya Viswanathan <[email protected]> 
wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   comments from Sandhya
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 693:
> 
>> 691: 
>> 692:     // Increment is now a constant step, 2 Ctrs at a time
>> 693:     __ vpbroadcastq(Increment, 2*blocksPerReg, vector_len, tmp);
> 
> May be better to say parallel*blocksPerReg?

I understand it better now: 2*blocksPerReg is correct.  Each block is 16 bytes. 
 Counter is split into 8 byte components and stored as ctrLow and ctrHigh. A 
vector register can hold blocksPerReg blocks. ctrLow/ctrHigh have 
2*blocksPerReg counter entries.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33128#discussion_r4496145747

Reply via email to