On Fri, 6 Nov 2026 17:59:37 GMT, Mohamed Issa <[email protected]> wrote:
>> The primary reason for this set of changes is to sanity check the >> **doubleKeccak** and **quadKeccak** methods. This includes their >> intrinsified and pure Java variants. The new JTREG source files listed below >> essentially validate return values from invoked private methods using the >> Java Reflection API. >> >> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java` >> 2. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java` >> 3. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java` >> >> Additionally, the multi block intrinsic tests now check the correct >> **implCompressMultiBlock0** method. All modifications and tests used >> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) >> as the baseline build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mohamed Issa has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Merge tag 'jdk-28+23' into user/missa-prime/crypto > > Added tag jdk-28+23 for changeset 2e25332f > - Correct SHA512 multi-block intrinsic reference to SHA1 intrinsic source > tests. > - Remove unnecessary buffers passed into keccak methods in invocation tests. > - Pass caught exceptions into constructors of newly thrown exceptions. > - Change test flags in some source files to match style of others. > - Fix trailing whitespace in InvokeSanityTestBase.java source file. > - Modify SHA tests exercise keccak methods. With fixes to the issues that I describe in the code review the relevant regression test results look good. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33709#issuecomment-6718440440
