On Fri, 13 Nov 2026 23:58:07 GMT, Shawn Emery <[email protected]> wrote:

>> This set of changes implements multiplication and squaring field operations 
>> on the P-384 curve using AArch64 intrinsics.  The performance gains from 
>> this enhancement yields:
>> 
>> Key pair generation - P-384: +38%
>> Key agreement - P-384: +37%
>> KEM decapsulation - secP384r1: +36%
>> KEM encapsulation - secP384r1: +36%
>> 
>> Key pair generation - secP384r1MLKEM1024: +35%
>> KEM decapsulation - secP384r1MLKEM1024: +35%
>> KEM encapsulation - secP384r1MLKEM1024: +36%
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Shawn Emery has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Remove unnecessary tmp variable
>  - Move to add/sub-shift instructions to separate shift add/sub instruction 
> set

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 9016:

> 9014:       __ mov(c[i], zr);
> 9015:     }
> 9016: 

The first thing that strikes me is that this looks like a straightforward 
translation of the version in the IntegerPolynomialP384 class. So from where 
comes the advantage, and how big is it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33618#discussion_r4536663305

Reply via email to