On Sat, 14 Nov 2026 18:09:25 GMT, Mohamed Issa <[email protected]> wrote:

>> The primary reason for this set of changes is to sanity check the 
>> **doubleKeccak** and **quadKeccak** methods. This includes their 
>> intrinsified and pure Java variants. The new JTREG source files listed below 
>> essentially validate return values from invoked private methods using the 
>> Java Reflection API.
>> 
>> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java`
>> 2. 
>> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java`
>> 3. 
>> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java`
>> 
>> Additionally, the multi block intrinsic tests now check the correct 
>> **implCompressMultiBlock0** method. All modifications and tests used 
>> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) 
>> as the baseline build.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Mohamed Issa has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use 8386578 instead of 8396624 for invocation test headers.

LGTM.  Thank you for the updates.

-------------

Marked as reviewed by semery (Committer).

PR Review: https://git.openjdk.org/jdk/pull/33709#pullrequestreview-5906340672

Reply via email to