Re: [GUMP@lsd]: xml-security/xml-security failed

Berin Lautenbach Wed, 24 Mar 2004 01:55:03 -0800

Erwin,

Do we need to support the Xalan library that came with 1.4? I thought we had put something in place to catch the use of that version and throw an exception? We then put instructions on the web site as to how to use the endorsed directory to over-ride the Xalan that caused the problem? Or did I miss the point of all of that :>.

Cheers,
        Berin

Erwin van der Koogh wrote:

compile.library:
    [javac] Compiling 145 source files to
/data3/gump/xml-security/build/classes     [javac]
/data3/gump/xml-security/build/src/org/apache/xml/security/Init.java:149:
m_functions has private access in org.apache.xpath.compiler.FunctionTable
    [javac]                for (int i = 0; i <
FunctionTable.m_functions.length; i++) {     [javac]
^
    [javac]
/data3/gump/xml-security/build/src/org/apache/xml/security/Init.java:150:
m_functions has private access in org.apache.xpath.compiler.FunctionTable
    [javac]                   FuncLoader loader =
FunctionTable.m_functions[i];     [javac]
^     [javac]
/data3/gump/xml-security/build/src/org/apache/xml/security/Init.java:156:
m_functions has private access in org.apache.xpath.compiler.FunctionTable
    [javac]                         FunctionTable.m_functions[i] =
funcHereLoader;     [javac]                                      ^
    [javac] 3 errors

From the FunctionTable cvs log entry from yesterday:

"Patch to hide static function table in FunctionTable class. We do not want to expose this table to others."

Guess Gump is doing it's job :)

But to the problem..

              /* The following tweak by "Eric Olson" <[EMAIL PROTECTED]>
               * is to enable xml-security to play with JDK 1.4 which
               * unfortunately bundles an old version of Xalan
               */
              FuncLoader funcHereLoader = new FuncHereLoader();

              for (int i = 0; i < FunctionTable.m_functions.length; i++) {
                 FuncLoader loader = FunctionTable.m_functions[i];

                 if (loader != null) {
                    log.debug("Func " + i + " " + loader.getName());

if (loader.getName().equals(funcHereLoader.getName())) { FunctionTable.m_functions[i] = funcHereLoader; } } }

This is pretty disturbing.. as it seems we are relying on this to fix quite another 1.4 bug, this time in Xalan. What would be the best course of action?

- Drop the code and possibly support for a few 1.4 versions.
 We would have to verify it at least works with the latest 1.4
- Try to get Xalan to reverse the patch

Does anyone know if there has been any discussion on the Xalan dev list about this?

Erwin

Re: [GUMP@lsd]: xml-security/xml-security failed

Reply via email to