Regarding 40897 (String comparisons using '==' causes validation errors
with some parsers):
There are a few additional minor changes required to complete the fix.
ElementCheckerImpl.FullChecker needs to override the
isNamespaceElement() method (see attached diff). Plus there's at least
one another instance in ElementProxy.length() method where
ElementChecker needs to be employed.
Apart from this it would be a +1 from me.
Thanks,
Vishal
on 03/11/2008 12:27 AM Sean Mullan wrote:
Hi all,
It has been almost a year since 1.4.1 was released, and many bugs and
rfes have been fixed and integrated since then. Therefore, I would
like to make a 1.4.2 release available soon, and have at least one or
two beta candidate releases before doing that.
Please let me know if you are ok with this plan:
[ ] +1
[ ] 0
[ ] -1
If -1, please explain why (such as I really need a fix for bug xxxx).
FYI, here are the bugs and rfes that have been fixed since 1.4.1:
Fixed rfe 42653: Add support for C14N 1.1 to Java implementation.
Fixed bug 44205: XMLX509Certificate.getX509Certificate() results
in certificate parsing error.
Fixed Bug 44177: when using xslt transformation there is problem
with xalan newline.
Small refactor for ElementProxy to get rid of the state, it was an
old vestige that where taking space and obfuscating the code.
Fixed bug 40897: String comparisons using '==' causes validation
errors with some parsers.
Fixed bug 43056: Library does not allow specify provider for
private key operations.
Fixed bug 44102: XMLCipher loadEncryptedKey error.
Fixed bug 43239: "No installed provider supports this key" when
checking a RSA signature against a DSA key before RSA key.
Fixed bug 42597: Unnecessary namespace declarations on Signature
children.
Fixed bug 42061: Method to disable XMLUtils.addReturnToElement.
Fixed bug 42865: Problem with empty BaseURI in
ResolverLocalFilesystem.
Fixed bug 43230: Inclusive C14n doesn't always handle xml:space &
xml:lang attributes correctly
Fixed bug 38668: Add XMLCipher.encryptData method that takes
serialized data as parameter.
Fixed bug 42866: Error when removing encrypted content in 1.4.1.
Fixed bug 42820: ClassLoader issue causing
NoSuchAlgorithmException loading Provider Implementation.
Thanks,
Sean
--- ElementCheckerImpl.java.bak 2008-03-11 12:50:49.931625000 +0530
+++ ElementCheckerImpl.java 2008-03-12 12:28:05.701413700 +0530
@@ -48,7 +48,17 @@
namespaceSHOULDBE +":"+ localnameSHOULDBE};
throw new XMLSecurityException("xml.WrongElement",
exArgs);
}
- }
+ }
+
+ public boolean isNamespaceElement(Node el, String type, String ns) {
+ if ((el == null) ||
+ (ns != null && !ns.equals(el.getNamespaceURI())) ||
+ !el.getLocalName().equals(type)){
+ return false;
+ }
+
+ return true;
+ }
}
/** An empty checker if schema checking is used */
