Dan, Sorry for the delayed review. My comments are below. I haven't reviewed the license files.
> Here's a review for AES optimization on OpenSolaris x86 64-bit: > 5072963 Need an optimized AES implementation for amd64 > > http://dan.drydog.com/reviews/5072963-aes/ > KY-1 usr/src/common/crypto/aes/aes_cbc_crypt.c I don't think this is needed since bcopy() has optimization for the word aligned case. Did you see any improved performance with this change? KY-2 The file usr/src/common/crypto/aes/aes_impl.c is missing from this webrev. I believe you need to modify that file so that the C routines for aes_encrypt_impl and aes_decrypt_impl are not used. KY-3 usr/src/common/crypto/aes/amd64/aes_amd64.s Does this assembly code follow the Solaris AMD64 ABI for parameter passing conventions? I am asking this because the code seems to have been originally developed for Windows OS. -Krishna
