- usr/src/uts/common/inet/ip/ip.c:7008-7012 I thought we didn't like comments with "XXX" in them nor the names (or nicknames, such as KEBE, which I gatehr is your nickname :) of developers in source files.
If a re-reading of RFCs 3947/8 is needed then, why not do it? I don't think we care about keepalive drop stats, but we should know if we do... - usr/src/uts/common/inet/ip/ip.c:7031,7045 I gather that ESP-in-UDP is fairly costly -- we re-compute the IP header checksum for what appears to be purely local purposes only, and we move around the ESP payload (ovbcopy(), right?). Probably no big deal since the systems using ESP-in-UDP (laptops, desktops at home) are hardly HPC systems and probably have bottlenecks other than the CPU, making this not a hot path, but maybe a comment is worthwhile in case it ever becomes a hot path. Nico --
