Milan Jurik wrote: <snip>
>> What about libsmb changes ? What about the rest of the changes ? >> > > No idea, you should go to people from CIFS server team. <snip> Alan Wright and team are okay with the changes so that is covered. >> webrev refreshed: >> http://cr.opensolaris.org/~vkotal/strsep_libc-webrev/ >> > > My knowledge of adding new functions to libc is limited, but I think the > webrev is OK. Please, ask CIFS server people for their oppinion or log > the second CR for CIFS server. Sorry for cross-posting but a) to get more code reviewers b) because the changes are touching lib/passwdutil (and SSH !) I am Cc'ing security-discuss as well. Could someone there take a look as well ? Basically, the question is whether it's okay to rip out bsd-strsep.c from lib/passwdutil and move it to libc. passwdutil is 3rd party as well but I cannot tell whether the original source comes with strsep() implementation or what are the future plans for syncing with upstream (where it lives, BTW ?). Thanks, v.
